[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gpsd-dev] [PATCH] ntpshmread.c is only used by ntpshmmon
|
From: |
Eric S. Raymond |
|
Subject: |
Re: [gpsd-dev] [PATCH] ntpshmread.c is only used by ntpshmmon |
|
Date: |
Wed, 16 Mar 2016 10:29:27 -0400 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
Robert Norris <address@hidden>:
>
> ----------------------------------------
> > Date: Thu, 10 Mar 2016 18:16:23 -0500
> > From: address@hidden
> > To: address@hidden
> > CC: address@hidden
> > Subject: Re: [gpsd-dev] [PATCH] ntpshmread.c is only used by ntpshmmon
> >
> > Leave it in the library, please. That's where it belongs architrecturally;
> > you don't know that future clients won't want it.
> > --
>
> Nothing is exposed via the C API interface of gps.h that could use it, so in
> IMHO it doesn't belong in libgps
>
> Secondly currently building with NTPSHM off, it still includes at least
> sys/ipc.h (in ntpshm.h) so it prevents building libgps on Windows;
> otherwise inclusion of gpsd_config.h and more #ifdefs would be required
>
> Thus moving it to only where it is used seemed the simplest solution.
>
> Alternatively one could move ntpshmread.c into libgpsd instead, in case some
> future other new gpsd *internal* client might want it.
>
> Rob.
>
>
Fair enough - moce it to libgpsd, then.
--
<a href="http://www.catb.org/~esr/";>Eric S. Raymond</a>