Re: [gpsd-dev] [PATCH] Add Windows versions of time related functions.

[Robert Norris]

>>>> Are we now ok with malloc()?
>>>
>>> I just did a pull of git HEAD, the searched for malloc. I see mo
>>> malloc() added i the last year.
>>>
>>> What am I missing?
>>
>> The patch that started this thread uses strdup() which calls malloc().
>
> Yeah, there it is. Good eye.
>
> Since the input (isotime) is a fixed length string it would be
> easy to get rid of the malloc(). Or, even better, there was never any
> reason to duplicate the input string at all. Patches anyone?
>

Quote from hacking.html:

"The <code>gpsd</code> daemon doesn't (though the client-side code does)."

Since this is only for Windows builds for libgps - it is only for the client 
side thus should be OK.

Rob.