Re: [gpsd-dev] bug in timehint.c:261 ntpshm_put

[Fred Wright]

On Mon, 28 Nov 2016, Robert Norris wrote:

> I don't see why the compiler is complaining.

Because you're looking at the wrong version of the source. :-)

> The full statement is:
>
>    gpsd_log(&session->context->errout, LOG_PROG,
>          "NTP: ntpshm_put(%s %s) %s @ %s\n",
>          session->gpsdata.dev.path,
>          (precision == -20) ? "pps" : "clock",
>          real_str, clock_str);

No, in 149f329e it was changed to:

    gpsd_log(&session->context->errout, LOG_PROG,
             "NTP: ntpshm_put(%s,%s) %s @ %s\n",
             session->gpsdata.dev.path,
             precision,
             real_str, clock_str);

without correcting the format string to reflect the change in the type.

Fred Wright