Re: [gpsd-dev] bug in timehint.c:261 ntpshm_put

[Robert Norris]

D'oh!.

I checked the git version in a directory, but forgot that my emacs session to look at the code would load from a different directory...

So yes the recent change in 149f329e needs a fix up.

--
Be Seeing You - Rob.
If at first you don't succeed,
then skydiving isn't for you.

---

From: gpsd-dev <gpsd-dev-bounces+address@hidden> on behalf of Fred Wright <address@hidden>
Sent: 28 November 2016 23:19:30
To: address@hidden
Subject: Re: [gpsd-dev] bug in timehint.c:261 ntpshm_put

 

On Mon, 28 Nov 2016, Robert Norris wrote:

> I don't see why the compiler is complaining.

Because you're looking at the wrong version of the source. :-)

> The full statement is:
>
>    gpsd_log(&session->context->errout, LOG_PROG,
>          "NTP: ntpshm_put(%s %s) %s @ %s\n",
>          session->gpsdata.dev.path,
>          (precision == -20) ? "pps" : "clock",
>          real_str, clock_str);

No, in 149f329e it was changed to:

    gpsd_log(&session->context->errout, LOG_PROG,
             "NTP: ntpshm_put(%s,%s) %s @ %s\n",
             session->gpsdata.dev.path,
             precision,
             real_str, clock_str);

without correcting the format string to reflect the change in the type.

Fred Wright