gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gpsd-dev] [PATCH 4/4] cppcheck: error - use of uninitialized variable


From: Robert Norris
Subject: [gpsd-dev] [PATCH 4/4] cppcheck: error - use of uninitialized variable
Date: Thu, 9 Feb 2017 23:17:12 +0000

Ensure mask is fully set.

TESTED:
'scons build-all check' still passes
---
 driver_nmea0183.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/driver_nmea0183.c b/driver_nmea0183.c
index 64b9de7c..58a61156 100644
--- a/driver_nmea0183.c
+++ b/driver_nmea0183.c
@@ -1632,7 +1632,7 @@ static gps_mask_t processPSTI(int count, char *field[],
     gps_mask_t mask;
 
     /* set something, so it won't look like an unknown sentence */
-    mask |= ONLINE_SET;
+    mask = ONLINE_SET;
 
     if ( 0 != strncmp(session->subtype, "Skytraq", 7) ) {
        /* this is skytraq, but marked yet, so probe for Skytraq */
@@ -1704,7 +1704,7 @@ static gps_mask_t processSTI(int count, char *field[],
     gps_mask_t mask;
 
     /* set something, so it won't look like an unknown sentence */
-    mask |= ONLINE_SET;
+    mask = ONLINE_SET;
 
     if ( 0 != strncmp(session->subtype, "Skytraq", 7) ) {
        /* this is skytraq, but marked yet, so probe for Skytraq */
-- 
2.11.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]