[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gpsd-dev] Fw: [gpsd-commit-watch] [SCM] GPSD branch, master, update
|
From: |
Fred Wright |
|
Subject: |
Re: [gpsd-dev] Fw: [gpsd-commit-watch] [SCM] GPSD branch, master, updated. release-3.17-356-ga7dadab |
|
Date: |
Sat, 29 Sep 2018 15:41:48 -0700 (PDT) |
|
User-agent: |
Alpine 2.21 (LRH 202 2017-01-01) |
On Thu, 27 Sep 2018, Gary E. Miller wrote:
On Thu, 27 Sep 2018 18:54:10 -0700 (PDT)
Fred Wright <address@hidden> wrote:
[...]
Having "scons check" launch an X11 server and/or fail if DISPLAY
isn't set appropriately is unacceptable.
Odd that I do not have that problem. I tested on over a dozen hosts
of wildly different configurations. If you do, lets find a real fix
that is not a regression.
It definitely behaves that way on the Mac (though perhaps not if you have
no X11 support installed).
Maybe a simple check for $DISPLAY and exit if unset? That woulda saved
you code.
Actually it's sort of the opposite. My recollection was incorrect about
the imports failing when DISPLAY is unset, and they don't bother to do the
X11 launch in that case. So the simple fix is to clear DISPLAY in
test-only cases (which aren't going to try to do any X11 display, anyway).
It might be nice if the case where xgps/xgpsspeed tries to actually use
X11 without a proper DISPLAY setting had a friendlier error message than a
segfault, but that isn't a new bug. :-)
I'm sure Bernd's Travis
checks would have failed as soon as you introduced that if they
hadn't stopped updating two months ago.
Dunno anything about that. Do you know who can fix that?
Bernd, presumably. I think his gpsd-mirror repo stopped mirroring.
This new check found a ton of bugs.
Quite likely so, but none that my better-behaved check wouldn't have
found.
Easy to say since you did not see my results. But not true.
Did you have any cases where cairo and gi imported successfully but there
were still missing prerequisites? Though it's moot now, anyway.
Fred Wright