Re: [gpsd-dev] [PATCH] driver_greis: fix build with reconfigure disabled

[zgyarmati]

Dear Gary&All,

On Dienstag, 9. Oktober 2018 20:33:45 CEST Gary E. Miller wrote:
> Yo Baruch!
> 
> On Tue,  9 Oct 2018 15:26:29 +0300
> 
> Baruch Siach <address@hidden> wrote:
> > Unhide the definition of greis_parse_input and greis_event_hook since
> > they are used unconditionally.
> 
> Thanks.  Patch applied, and now in git head.  There will be a 13.1
> release in the next and this will be in it.
> 
> Can you explain why you build with RECONFIGURE_ENABLE disbled?  Never
> made sense to me.  We are considering what #ifdef can be removed and
> that one is high on my list.

 Disabled RECONFIGURE_ENABLE happens to be the default in Buildroot, that's 
why we hit this issue in a Buildroot autobuild job (see the build log at [1]), 
and and i suppose this is also how Baruch has noted this. Therefore there is 
no special use-case in the background, only thorough build testing :)

 If you think it's reasonable to flip this default, probably we'll do it in 
the Buildroot package definition. On the other hand if it's going to be 
removed anyway, i think we will not bother.
 

[1]http://autobuild.buildroot.net/results/a13/
a13a5d852c83cd1fc9f2d1fc2b7302db515278b8/build-end.log

> 
> RGDS
> GARY
> ---------------------------------------------------------------------------
> Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
>       address@hidden  Tel:+1 541 382 8588
> 
>           Veritas liberabit vos. -- Quid est veritas?
>     "If you can’t measure it, you can’t improve it." - Lord Kelvin

Regards
Zoltan Gyarmati
https://zgyarmati.de