Re: [PATCH 2/3] SConstruct: Use target_python when constructing extension name

[Ladislav Michl]

On Tue, Feb 04, 2020 at 02:28:42PM -0800, Gary E. Miller wrote:
> Yo Ladislav!
> 
> On Tue, 4 Feb 2020 01:13:56 +0100
> Ladislav Michl <address@hidden> wrote:
> 
> > > Or maybe target_python is starting an emulation environment and
> > > running the target python in it?  
> > 
> > It is not exactly emulation environment, it is rather cross-python.
> > So it is very same version as target_python, but running on host
> > aiming at target. Consider it an aid for situations as this one.
> 
> Very bad assumption.  Not gonna put that in SConstruct.

I see, SConstruct is so special widely used solution is not good enough.
Also, what are you not going to put in SConstruct?

> > > "target_python" is intended so you can built gpsd for one local
> > > python, say python3.7, while scons is running on another local
> > > python, say python2.7.
> > > 
> > > Or am I missing something?  
> > 
> > No, you are right. I'm open to whatever solution not naming modules
> > after scons python. It is rather minor issue as these names are not
> > used on target system anyway.
> 
> Lost me.  What names are you talking about?  I was talking about
> getPythonValue().

I'm assuming you are aware with rationale of getPythonValue() existence.
See 1c26179ddb12 ("Adds "target Python" support to SConstruct.")
I'm picking relevant part here:
    The primary effect of this is to allow the C extensions to be built
    appropriately for a given Python version, but it also means that all
    Python code used for tests is executed with the target Python (which
    is necessary in some cases, and desirable for consistency in all
    cases).
So, we are using target_python as the one to build C extensions against.
Therefore extension name should be based on target_python's version.
As we are already doing the same when asking for config vars, when
deciding whenever to build aiogps, when checking for pyserial, pycairo
and pygobject. This patch just makes it aligned with that logic.

Best regards,
        ladis