Re: [PATCH] systemd/*: Use @SBINDIR@.

[Gary E. Miller]

Yo Ladislav!

I'm glad to see people looking at this now, but way too close to
release...

On Mon, 3 Aug 2020 11:29:30 +0200
Ladislav Michl <ladis@linux-mips.org> wrote:

> +    ('@SBINDIR@',    installdir('sbindir', add_destdir=False)),

I dont think this does what you think.  'sbindir' is 'sbin'.

> -ExecStart=/usr/local/sbin/gpsd $GPSD_OPTIONS $OPTIONS $DEVICES
> +ExecStart=@SBINDIR@/gpsd $GPSD_OPTIONS $OPTIONS $DEVICES

That seems fair to me.

> -ExecStart=/bin/sh -c "[ \"$USBAUTO\" = true ] &&
> /usr/local/sbin/gpsdctl add /dev/%I || :" -ExecStop=/bin/sh -c "[
> \"$USBAUTO\" = true ] && /usr/local/sbin/gpsdctl remove /dev/%I || :"
> +ExecStart=/bin/sh -c "[ \"$USBAUTO\" = true ] && @SBINDIR@/gpsdctl
> add /dev/%I || :" +ExecStop=/bin/sh -c "[ \"$USBAUTO\" = true ] &&
> @SBINDIR@/gpsdctl remove /dev/%I || :"

That really needs comments.  Just this week I have seen several people
totally misunderstand what that does.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        gem@rellim.com  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can't measure it, you can't improve it." - Lord Kelvin

pgpveputi6gqs.pgp
Description: OpenPGP digital signature