gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Git][gpsd/gpsd][master] 3 commits: SConstruct: Add automatic pdb br


From: Gary E. Miller
Subject: Re: [Git][gpsd/gpsd][master] 3 commits: SConstruct: Add automatic pdb breakpoint.
Date: Mon, 3 Aug 2020 13:17:24 -0700

Yo Fred!

I'm going to revert e60579c437: 
    SConstruct: Make python_shebang more convenient.

Many problems with it.

It imposes the constraint that the python_shebang must start with a
os.path.sep, a slash on Linux.  This prevents the use of many
valid shebangs.

Shebangs are defined in man execve(2).  They may start with white
space and the example at the top of the man page does so:

    #! interpreter [optional-arg]

The man page later says:

    "The interpreter must be a valid pathname for an executable which is
    not itself a script."

Nothing about it having to be an absolute path.

It also breaks shebangs with single quotes, double quotes, or Winblows
style:

    #!"C:\Python33\python.exe"

PEP 397 (https://www.python.org/dev/peps/pep-0397/)  is also on point.
Its first example uses white space, like this:

    #! interpreter [optional-arg]

PEP 397 also calls out as valid:

    #!python

So the patch that enforces the shabang to start with os.path.sep, or
have /usr/bin/env appended, does not conform to existing practice or
PEP 397,


RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        gem@rellim.com  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can't measure it, you can't improve it." - Lord Kelvin

Attachment: pgp4OOUAVT09q.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]