gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ✘asciidoc vs asciidoctor, issue #118


From: Greg Troxel
Subject: Re: ✘asciidoc vs asciidoctor, issue #118
Date: Thu, 28 Jan 2021 07:58:22 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (berkeley-unix)

"Gary E. Miller" <gem@rellim.com> writes:

>> If I specify that manbuild=yes , and asciidoctor is not available, I
>> get a warning, but the build completes (as does the install).
>> 
>> This is surprising.  Perhaps if manbuild=yes , the warning should be a
>> failure?
>
> I don't think it has ever been an error.  Since the default is
> manbuild=yes, it would be annoying to hard fail.
>
> Easy to change if anyone feels strongly about it.

(If asciidoctor is available a default build should build the docs,
obviously, and uncontroversially.)

My opinion, for cases when asciidoctor is not available:

  If one does the build without saying an explicit manbuild=yes, the
  build must succeed and simply not build the docs.  asciidoctor is not
  that hard to install, but it's not something that can be expected to
  be present on any reasonable system.

  If one does say manbuild=yes, a failure is appropriate.


This leads to variables having values no/auto/yes, where auto means yes
with a warning only if no tool and yes means fail if no tool.   A bunch
of work that I have no desire to do, but if somebody else did I'd see it
as an improvement.

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]