RE: Quectel FW version - Merge Request

[Jared Hagel]

Hi Gary,

I tried to make this a merge request, but I got this following 'Rejected' email 
when I tried to do so. I'm not sure what I did wrong.

Anyways, as requested I modified the lines of code I added to be less than 80 
characters and attached debug output. You can see the text 'PQVERNO' in this 
debug output. If you let me know which code I added is insecure I can fix that 
as well.

Thank you,
Jared

> From: gitlab@mg.gitlab.com <gitlab@mg.gitlab.com> 
> Sent: Friday, March 4, 2022 4:10 PM
> To: Jared Hagel <jared.hagel@vontas.com>
> Subject: [Rejected] Quectel FW version - Merge Request

> EXTERNAL: Do not click links or open attachments if you do not recognize the 
> sender.
> Unfortunately, your email message to GitLab could not be processed. 
> You are not allowed to perform this action. If you believe this is in error, 
> contact a staff member.

-----Original Message-----
From: gpsd-dev <gpsd-dev-bounces+jared.hagel=vontas.com@nongnu.org> On Behalf 
Of Gary E. Miller
Sent: Friday, March 4, 2022 3:46 PM
To: gpsd-dev@nongnu.org
Subject: Re: Quectel FW version - Merge Request

Yo Jared!

On Fri, 4 Mar 2022 22:30:01 +0000
Jared Hagel <jared.hagel@vontas.com> wrote:

> We have a requirement to retrieve the Quectel FW version of our 
> Quectel (MTK3301) GPS receiver, so I was hoping to have the attached 
> change merged into GPSD. I've tested this on our hardware and it works 
> fine for us. Let me know what you think.

Good start, but is not secure code.  I'll take a look at it.
Also some formatting problems, like the lines longer than 80 columns.

Can you provide a raw data capture that include the PQVERNO message?

Can you make this am Merge Request to make it easier to review.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        gem@rellim.com  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can't measure it, you can't improve it." - Lord Kelvin

patch.diff
Description: patch.diff

DebugOutput.txt
Description: DebugOutput.txt