[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Ten patches for xgps
From: |
Fred Wright |
Subject: |
Re: Ten patches for xgps |
Date: |
Thu, 18 Jul 2024 13:16:12 -0700 (PDT) |
On Thu, 18 Jul 2024, Gary E. Miller wrote:
Please make these individual Merge Requests.
I'm not sure whether per-commit MRs, or a single MR for all of them, or
something in between, is the best choice, but patches via email certainly
isn't. Patches via email are more tedious and more error-prone for all
parties concerned.
The main criterion for including multiple commits in one MR is the
expectation that they share a common criterion for acceptance. If they
do, then a single MR is more convenient. But if they have differing
expectations for acceptance, then putting them in different MRs avoids the
need for partial merging. Though splitting them up gets more complicated
if they're interdependent.
As far as pylint goes, note that different versions of pylint may behave
differently, and making something work better for one version sometimes
makes it work worse for another. An especially obnoxious property is
where a given version of pylint complains about trying to disable a
warning that it doesn't know about, which is *really* stupid.
Essentially, it goes:
User: "Don't warn me about X."
Pylint: "I don't know about X, so I'll warn you about telling me not to
warn you about it."
Fred Wright
On Thu, 18 Jul 2024 10:05:15 -0700
James Browning <jamesb192@jamesb192.com> wrote:
Here are ten patches intended to raise the pylint score of xgps; they
should be roughly order independant although some overlap. They
should be considered after other contributers work. I am mostly not
going to defend them, I think they should speak for themselves. So
much for keeping them to a single topic.
cairo has FontSlant and FontWeight classes both of which have a
NORMAL constant.