Re: Whats the purpose of having sizeof_time_t in the SConstruct?

[Gary E. Miller]

Yo raaj!

On Wed, 17 Jun 2020 11:39:02 +0800
raaj lokanathan <raaj5671.rl@gmail.com> wrote:

> I mean the current git head commit,

This is last git head commit:

------------------
xommit db22e0f8669faa74d76b9e8592d743041855bd6f (HEAD -> master, origin/master, 
origin/HEAD)
Author: Gary E. Miller <gem@rellim.com>
Date:   Mon Jun 15 21:56:48 2020 -0700

    SConstruct: Fix stupid typo...

diff --git a/SConstruct b/SConstruct
index fad1e838f..3f9bfe399 100644
--- a/SConstruct
+++ b/SConstruct
@@ -560,7 +560,7 @@ for i in ["AR",      # linker for static libs, usually "ar"
           "STRIP",
           "TAR"]:
     if i in os.environ:
-        env[i] = os.getenv(j)
+        env[i] = os.getenv(i)

------------------

That fixed breakage in 3.20 when cross compiling.  Resolved a nasty bug.

Is that a problem for you?  If so, please provide complete build logs
of what you see.

> just skips the checking for the
> size of time_t.

Uh?  The current git head commit has nothing to do with sizeof(time_t)?

As of recently, but long before git head, gpsd has been checking
sizeof(time_t) and will continue to do so.

No reported issues with it.

> Is this the permanent solution?

Everything in gpsd is subject to change if someone raises an issue.

Right now, the only open issues I know of are in the GitLab issues
tracker and the Merge Requests.

> Because in 3.19 I didn't see this checking.

3.19 is pretty old, a lot has changed.  Both in 3.20 and in git
head.  Checking sizeof(time_t) was added due to the Linux kernel
changes to support 32-bit time_t.

The sizeof(time_t) check does not change any code, it is to warn
the person building gpsd that their libc needs updating.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        gem@rellim.com  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can't measure it, you can't improve it." - Lord Kelvin

pgpILygYVMZak.pgp
Description: OpenPGP digital signature