gpsd-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Using SNMP...


From: Gary E. Miller
Subject: Re: Using SNMP...
Date: Tue, 31 Jan 2023 15:30:58 -0800

Yo David!

On Tue, 31 Jan 2023 15:28:13 +0000
David Taylor <davidtaylor@writeme.com> wrote:

> I have one difference between your method and mine of calculating
> average SNR, where you get a much smaller value.  I calculate SNR
> based on the satellites which are used, whereas you seem to get a
> much smaller value possibly by averaging the SNR over the visible
> satellites.

Nope.  Here is the code:

        for(i = 0; i <= gpsdata.satellites_used; i++) {
            if (0 < gpsdata.skyview[i].used &&
                1 <  gpsdata.skyview[i].ss) {
                // printf("i: %d, P:%d, ss: %f\n", i, gpsdata.skyview[i].PRN,
                //         gpsdata.skyview[i].ss);
                snr_total += gpsdata.skyview[i].ss;
            }
        }

Looks like the for loop end point is wrong.  Should be:

        for(i = 0; i <= MAXCHANNELS; i++) {

To check the entire table.  Fix pushed.

> I can see arguments for both cases, so might I request a new value 
> "skySNRavgused" or something like that?  So only computing the SNR
> over the satellites with the used flag set.

Don't make arguments from bad assumptions.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        gem@rellim.com  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can't measure it, you can't improve it." - Lord Kelvin

Attachment: pgpXOeVlgjq5O.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]