|
From: | Paul Eggert |
Subject: | Re: [Grep-devel] avoiding new warnings |
Date: | Tue, 23 May 2017 02:39:24 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 |
Jim Meyering wrote:
the false positives should be sufficiently rare that it's worth leaving it on by default. It might catch me doing something stupid even before I run a test
It might. On the other hand, every warning that -Wduplicated-branches generated for grep (3 warnings) and for Emacs (4 warnings) was a false alarm. Yes, we can pacify GCC for each false alarm, but so far -Wduplicated-branches' cost/benefit ratio has been infinity and this is not a good sign.
I wouldn't bother changing kwset.c back, unless there's a need; we both have better things to do that worry about this.
[Prev in Thread] | Current Thread | [Next in Thread] |