Re: [Grep-devel] handling of non-BMP characters

[Corinna Vinschen]

On Dec 16 21:48, Corinna Vinschen wrote:
> On Dec 16 12:35, Jim Meyering wrote:
> > On Sun, Dec 16, 2018 at 12:00 PM Corinna Vinschen <address@hidden> wrote:
> > ...
> > > I also don't quite get the point where Cygwin is getting the blame for a
> > > screwed-up commit sequence in grep.
> > 
> > Hi Corinna,
> > 
> > The code that's been disconnected since grep-2.21 (from 2014-11-23)
> > was cygwin-specific:
> > 
> > -#ifdef __CYGWIN__
> > -      /* Handle a UTF-8 sequence for a character beyond the base plane.
> > -         Cygwin's wchar_t is UTF-16, as in the underlying OS.  This
> > -         results in surrogate pairs which need some extra attention.  */
> 
> Oh, I guess I misunderstood what you wrote:
> 
>   "I suppose it's a regression on Cygwin"
> 
> I interpreted this as "it's a bug *in* Cygwin" but you simply said it
> occurs on Cygwin only, right?
> 
> 
> Sorry,
> Corinna

In terms of that patch, even if nobody noticed it for a long time,
because 90% of humanity is mostly using the BMP chars, it would be
pretty nice if that code could get reverted back in to support
non-BMP charsets even on Cygwin.


Thanks,
Corinna