[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] dfa: new option DFA_STRAY_BACKSLASH_WARN

From: Paul Eggert
Subject: Re: [PATCH 2/3] dfa: new option DFA_STRAY_BACKSLASH_WARN
Date: Fri, 24 Jun 2022 18:45:19 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1

On 6/23/22 00:37, Jim Meyering wrote:
On Mon, Jun 6, 2022 at 3:06 PM Paul Eggert <> wrote:
On 6/6/22 12:37, Jim Meyering wrote:
Once you push that (and assuming you have nothing else pending), I'll
prepare another pre-release snapshot.
Thanks, I pushed it into grep master, after fixing the commentary issue
Bruno noted.
I was going to make a snapshot, but figured I should first run the
usual *SAN check:
i.e., configure && make as usual, but then "make clean" followed by
this on a linux system:

san='-fsanitize-address-use-after-scope -fsanitize=address
ASAN_OPTIONS=detect_leaks=1,allocator_may_return_null=1 make
CFLAGS='-O0 -ggdb3' AM_CFLAGS="$san" AM_LDFLAGS="$san" check

and it failed nearly every test, all due to leaks.

You can see a few leaks with an even simpler test using valgrind and a
no-ASAN binary:
(this was with the patch attached below, which fixed the first one I found)

Thanks for catching that. These are minor memory leaks in grep, not in Gnulib, and I fixed it by installing the attached into Grep. With it, all the Grep tests pass with your recipe. There are a few Gnulib failures in the memory-management modules but I expect these are merely the usual suspects.

Attachment: 0001-grep-fix-regex-compilation-memory-leaks.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]