[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 02/10: tmac/mdoc/doc-common-u: Fix style problems.

From: G. Branden Robinson
Subject: [groff] 02/10: tmac/mdoc/doc-common-u: Fix style problems.
Date: Thu, 17 Sep 2020 05:20:28 -0400 (EDT)

gbranden pushed a commit to branch master
in repository groff.

commit 8afa6fb1876c052014d5cdc80609c5ad52566d98
Author: G. Branden Robinson <>
AuthorDate: Wed Sep 16 21:42:10 2020 +1000

    tmac/mdoc/doc-common-u: Fix style problems.
    Correct misleading indentation.
    Also fix spelling of register name.  Despite appearances, this wasn't
    actually a typo but a deliberate mispelling; I learned in the course of
    implementing 0438b1b905ebe9ac5fc678af06db911d25c3a030 (14 September)
    that removing a non-existent register was not an error (or even a
    warning) condition.  I looked briefly into adding code to warn about it,
    found it difficult--the string that's used for lookup in the register
    dictionary seems to not actually be in the scope of `remove_reg()`,
    which implements the '.rr' request--at any rate it's not a "symbol"
    because undefined symbols are reasonably enough not in the troff symbol
    table, and I don't know the class hierarchy well enough to guess where
    else it might be.  I then forgot to revert the change I was using to try
    to provoke the diagnostic, and didn't notice because...there's no
    diagnostic.  (One could still be emitted from `remove_reg()`, but it
    wouldn't be able to include the name of the unrecognized identifier, and
    I consider that too user-hostile to bother with.)  Anyway, this is an
    object lesson in using "XXX" comments.
 tmac/mdoc/doc-common-u | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tmac/mdoc/doc-common-u b/tmac/mdoc/doc-common-u
index f98c077..1c83ff7 100644
--- a/tmac/mdoc/doc-common-u
+++ b/tmac/mdoc/doc-common-u
@@ -1140,9 +1140,9 @@
 .  \}
 .  el \
 .    ds doc-sec-head "\$*
-.    rm doc-str-tmp1
-.    rm doc-str-tmp2
-.    rr doc-tmp-strleq
+.  rm doc-str-tmp1
+.  rm doc-str-tmp2
+.  rr doc-tmp-strlen

reply via email to

[Prev in Thread] Current Thread [Next in Thread]