groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 06/23: [libgroff]: Drop redundant diagnostic.


From: G. Branden Robinson
Subject: [groff] 06/23: [libgroff]: Drop redundant diagnostic.
Date: Thu, 23 Sep 2021 08:12:32 -0400 (EDT)

gbranden pushed a commit to branch master
in repository groff.

commit d43f0a9c941ab087a4a862217fef58d27f52341b
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Thu Sep 23 09:19:05 2021 +1000

    [libgroff]: Drop redundant diagnostic.
    
    * src/libs/libgroff/font.cpp (font::load): Drop redundant diagnostic; a
      missing `charset` directive is already checked for later, circa line
      998.
---
 ChangeLog                  | 8 ++++++++
 src/libs/libgroff/font.cpp | 8 +-------
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 71772a2..0a29acc 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2021-09-23  G. Branden Robinson <g.branden.robinson@gmail.com>
+
+       [libgroff]: Drop redundant diagnostic.
+
+       * src/libs/libgroff/font.cpp (font::load): Drop redundant
+       diagnostic; a missing `charset` directive is already checked for
+       later, circa line 998.
+
 2021-09-22  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        [libgroff]: Fix code style nits.
diff --git a/src/libs/libgroff/font.cpp b/src/libs/libgroff/font.cpp
index e3a3981..01c1144 100644
--- a/src/libs/libgroff/font.cpp
+++ b/src/libs/libgroff/font.cpp
@@ -848,13 +848,7 @@ bool font::load(bool load_header_only)
       break;
   }
   bool had_charset = false;
-  if (0 == p) {
-    if (!is_unicode) {
-      t.error("'charset' directive is missing");
-      return false;
-    }
-  }
-  else {
+  {
     char *directive = p;
     t.recognize_comments = false;
     while (directive) {



reply via email to

[Prev in Thread] Current Thread [Next in Thread]