groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 09/38: [eqn]: Warn of -p, -s deprecation on use.


From: G. Branden Robinson
Subject: [groff] 09/38: [eqn]: Warn of -p, -s deprecation on use.
Date: Fri, 2 Sep 2022 19:56:30 -0400 (EDT)

gbranden pushed a commit to branch master
in repository groff.

commit 569a73329b030efb4ab2d6bc38a4e824240eced8
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Sun Aug 28 16:45:04 2022 -0500

    [eqn]: Warn of -p, -s deprecation on use.
    
    * src/preproc/eqn/main.cpp (main): Issue deprecation warning upon use of
      '-p' or '-s' options.  The eqn(1) man page has documented these as
      deprecated since at least groff 1.02 (June 1991).  Don't count on them
      sticking around another 30 years.
---
 ChangeLog                | 7 +++++++
 src/preproc/eqn/main.cpp | 8 ++++++--
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 224a33004..872beba4b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2022-08-28  G. Branden Robinson <g.branden.robinson@gmail.com>
+
+       * src/preproc/eqn/main.cpp (main): Issue deprecation warning
+       upon use of '-p' or '-s' options.  The eqn(1) man page has
+       documented these as deprecated since at least groff 1.02 (June
+       1991).  Don't count on them sticking around another 30 years.
+
 2022-08-28  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        * src/preproc/eqn/main.cpp (main): Clarify error diagnostics
diff --git a/src/preproc/eqn/main.cpp b/src/preproc/eqn/main.cpp
index a707d5115..0a593f942 100644
--- a/src/preproc/eqn/main.cpp
+++ b/src/preproc/eqn/main.cpp
@@ -334,14 +334,18 @@ int main(int argc, char **argv)
       }
       break;
     case 's':
-      if (!set_gsize(optarg))
+      if (set_gsize(optarg))
+       warning("option '-s' is deprecated; see eqn(1) man page");
+      else
        error("invalid size '%1' in '-s' option argument ", optarg);
       break;
     case 'p':
       {
        int n;
-       if (sscanf(optarg, "%d", &n) == 1)
+       if (sscanf(optarg, "%d", &n) == 1) {
+         warning("option '-p' is deprecated; see eqn(1) man page");
          set_script_reduction(n);
+       }
        else
          error("invalid size '%1' in '-p' option argument ", optarg);
       }



reply via email to

[Prev in Thread] Current Thread [Next in Thread]