[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 19/20: pic(1): Fix content, style, and markup nits.

From: G. Branden Robinson
Subject: [groff] 19/20: pic(1): Fix content, style, and markup nits.
Date: Thu, 24 Nov 2022 22:11:36 -0500 (EST)

gbranden pushed a commit to branch master
in repository groff.

commit c89abc5d0aabab8ec4839f38bba9cad46ea5b5a7
Author: G. Branden Robinson <>
AuthorDate: Thu Nov 24 20:37:30 2022 -0600

    pic(1): Fix content, style, and markup nits.
    * Fix incorrect cross reference.  The (g)troff(1) man page does not
      document the language's requests.
    * Use `BR` macro instead of font selection escape sequences.  I'll bet I
      know why the latter were used here when `BR` was employed earlier in
      the same paragraph: the old Unix Version 7 man(7) six-argument limit.
      I suspect most rendering of groff's man pages will be done with modern
      implementations.  If that's wrong, we will have other issues to
      resolve (like groff-style special character escape sequences and
      string interpolations), but for the problem at hand I prefer `\c` and
      multiple font style macros where necessary.
    * Recast the discussion of color modifiers as one paragraph.
    * Use EX/EE to set an example.
    * Stop setting a groff request name with a leading dot when it is not
      ambiguous (and if it is, quotation along with boldface is better).
    * Tighten wording.
    * Use active voice more.
 src/preproc/pic/ | 37 +++++++++++++++----------------------
 1 file changed, 15 insertions(+), 22 deletions(-)

diff --git a/src/preproc/pic/ b/src/preproc/pic/
index 5fd474af3..07c8d1bc9 100644
--- a/src/preproc/pic/
+++ b/src/preproc/pic/
@@ -1159,41 +1159,34 @@ has been filled,
 so that the text will not be obscured by the filling.
-Three additional modifiers are available to specify colored objects:
+Additional modifiers are available to draw colored objects:
 .BR outline [ d ]
 sets the color of the outline,
 .B shaded
 the fill color,
-.B colo\fR[\fPu\fR]\fPr\fR[\fPed\fR]
+.BR colo [ u ] r [ ed ]
 sets both.
-All three keywords expect a suffix specifying the color,
-as shown below.
+All expect a subsequent string argument specifying the color.
-.B circle shaded """green""" outline """black"""
+circle shaded \[dq]green\[dq] outline \[dq]black\[dq]
+Color is not yet supported in \*[tx] mode.
-color support isn't available in \*[tx] mode.
-Predefined color names for
-.I groff
-are in the device macro files,
-for example
-.BR ps.tmac ;
-additional colors can be defined with the
-.B .defcolor
+Device macro files like
+.I ps.tmac
+declare color names;
+you can define additional ones with the
+.B defcolor
-(see the manual page of
-.MR @g@troff @MAN1EXT@
-for more details).
+.MR groff @MAN7EXT@ ).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]