groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 25/36: [mm]: Reject invalid argument values > 1 to `SA`.


From: G. Branden Robinson
Subject: [groff] 25/36: [mm]: Reject invalid argument values > 1 to `SA`.
Date: Tue, 17 Jan 2023 20:45:13 -0500 (EST)

gbranden pushed a commit to branch master
in repository groff.

commit 190122c83c27182f9bc2baff7aa638eed6f1931c
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Mon Jan 16 16:33:00 2023 -0600

    [mm]: Reject invalid argument values > 1 to `SA`.
    
    * contrib/mm/m.tmac (SA): Reject an argument value > 1 as invalid.
    
    Also recast diagnostic message to refer to "invalid", not "bad" input.
    See, e.g., bb7512b57a, 17 September 2021.
---
 contrib/mm/ChangeLog | 4 ++++
 contrib/mm/m.tmac    | 3 ++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/contrib/mm/ChangeLog b/contrib/mm/ChangeLog
index 60a4b4657..ac95bbbe2 100644
--- a/contrib/mm/ChangeLog
+++ b/contrib/mm/ChangeLog
@@ -1,3 +1,7 @@
+2023-01-16  G. Branden Robinson <g.branden.robinson@gmail.com>
+
+       * m.tmac (SA): Reject an argument value > 1 as invalid.
+
 2023-01-16  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        * m.tmac (P): Quote unrecognized argument in warning diagnostic.
diff --git a/contrib/mm/m.tmac b/contrib/mm/m.tmac
index 5f90c628d..11381f419 100644
--- a/contrib/mm/m.tmac
+++ b/contrib/mm/m.tmac
@@ -527,7 +527,8 @@ in=\\n[.i] fi=\\n[.u] .d=\\n[.d] nl=\\n[nl] pg=\\n[%]
 .nr misc@adjust 14
 .de SA
 .if \\n[.$] \{\
-.      if \\$1-1 .@error "SA: bad arg: \\$1"
+.      if ((\\$1 < 0) : (\\$1 > 1)) .@error \\$0: invalid argument \
+'\\$1'
 .\" XXX: ...then...
 .\"   .ad l
 .\"   .nr misc@adjust \\n[.j]



reply via email to

[Prev in Thread] Current Thread [Next in Thread]