Re: [Groff] PDFPIC macro

[Werner LEMBERG]

>>   // Private method functions facilitate implementation of
>>   // the class constructor.
>> 
>> I consider as completely unnecessary, since it is basic C++
>> knowledge how data in the `private' section works.
> 
> In this case, the intent is to emphasize that there is no user,
> besides the constructor itself, of any of the private functions;
> [...]

Then write exactly that in the comment!

>> A last thing regarding your comment style: Given that today's
>> editors support various colors for comments, data types, etc., I
>> think it's better to change [...]
>
> - even with syntax highlighting turned on, I find your style to be
> more difficult to read, simply because the boundary between comment
> and code is obscured when the vertical spacing is omitted.

OK.

>> Well, `register' is deprecated in the C++11 standard.
> 
> Well, groff isn't C++11, [...]

But the future of C++ compilers is to default to C++11!  So we have to
assure that it compiles with no useless warnings.

Again: thanks for working on this, please commit.


    Werner