[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Groff] Build broken - Improve native Windows port

From: Bertrand Garrigues
Subject: [Groff] Build broken - Improve native Windows port
Date: Sat, 29 Nov 2014 12:32:27 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)


On Thu, Nov 20 2014 at 07:46:16 PM, Werner LEMBERG <address@hidden> wrote:
> wl pushed a commit to branch master
> in repository groff.
> commit 6360d7c66deea677de7260e1efacfce3daa55d85
> Author: Eli Zaretskii <address@hidden>
> Date:   Thu Nov 20 19:45:17 2014 +0100
>     Improve native Windows port.
>     This patch fixes two issues.
>       . Handle backslashes in `.lf' arguments for MSDOS and Windows.
>       . Fix file name quoting for the groff pipeline.
>     * src/preproc/soelim/soelim.cpp (do_file):
>     * src/preproc/refer/refer.cpp (do_file):
>     * src/preproc/preconv/preconv.cpp (do_file):
>     * src/preproc/pic/main.cpp (do_file):
>     * src/preproc/eqn/main.cpp (do_file): Call `normalize_for_lf' to
>     convert backslashes in the file name being processed to forward
>     slashes.
>     * src/include/lib.h (normalize_for_lf): Add prototype.
>     * src/preproc/eqn/eqn.h:
>     * src/preproc/pic/pic.h:
>     * src/preproc/refer/refer.h:
>     * src/preproc/tbl/table.h: Include stringclass.h before lib.h.
>     * src/libs/libgroff/lf.cpp (normalize_for_lf): New function.
>     * src/roff/groff/groff.cpp: Include stringclass.h before lib.h.
>     (append_arg_to_string) [_WIN32 && !__CYGWIN__]: Use only "..." for
>     quoting in native Windows builds.

When building at revision  6360d7c66deea677de7260e1efacfce3daa55d85

I have this error:

In file included from [...] src/libs/libgroff/color.cpp:23:0:

 error: variable or field ‘normalize_for_lf’ declared void void
 normalize_for_lf (string &fn);

error: ‘string’ was not declared in this scope

This is because of the new function declaration 

void normalize_for_lf (string &fn);

After adding a

#include "stringclass.h" 


#include "lib.h" 

in color.cpp I found out that a lots of file have the problem.  I think
lib.h should include stringclass.h.  This would require some cleaning
though because I remember that the design in Groff is that the headers
are not guarded by #ifndef HEADER_NAME, and a lots of files include


Bertrand Garrigues

reply via email to

[Prev in Thread] Current Thread [Next in Thread]