[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [groff] 1.22.4.rc4 - Final RC before official 1.22.4

From: G. Branden Robinson
Subject: Re: [groff] 1.22.4.rc4 - Final RC before official 1.22.4
Date: Sun, 9 Dec 2018 00:17:57 -0500
User-agent: NeoMutt/20180716

At 2018-12-09T05:12:25+0100, Ingo Schwarze wrote:
> Here is a better idea, which is also simpler.
> The problem is that the variables PREFIXMAN5 and PREFIXMAN7 are empty.
> Carefully inspecting the groff source tree with grep(1), i convinced
> myself that they are *always* empty, no matter the configuration
> and operating system.  While several *.am Makefile templates assign
> to the variable PREFIXMAN1, all section 5 and 7 manual page file
> names are directly assigned to man5_MANS and man7_MANS instead,
> unconditionally.
> So i suggest to simply delete the PREFIXMAN5 and PREFIXMAN7 variables
> outright.  With the patch appended below, everything works on OpenBSD,
> Solaris 11, and Solaris 9, even "make install" on Solaris 9.
> I admit this change may be slightly more dangerous than i like so
> closely before release - but i'm not convinced other fixes would be
> simpler.
> Shall i commit and push it?

I didn't test it, but I eyeballed all the *.am files with grep and I
think you're right.

PREFIXMAN{5,7} appears to keep track of man pages in sections 5 and 7
that need a @g@ prefixed to their names--but there are no such pages.

So I'm a +1 on this.


Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]