Re: groff 1.23.0.rc4 on BSD-like systems

[G. Branden Robinson]

At 2023-04-15T23:22:25+0200, Bruno Haible wrote:
> On the systems
>   - Alpine Linux
>   - macOS
>   - FreeBSD
>   - NetBSD
>   - OpenBSD
>   - Cygwin
> the "make check" part of the build fails, trying to generate the file
> contrib/mom/examples/tests-mom.sh . For example:

At first I thought this was all my fault, arising from this change 6
weeks ago:

https://git.savannah.gnu.org/cgit/groff.git/commit/?id=1ec02e805e2448bb17a27e3d9398cc83fd272743

...but...

> $ make check
> ...
> make  check-TESTS
> make[2]: Entering directory '/home/bruno/groff-1.23.0.rc4/build-64'
> make[3]: Entering directory '/home/bruno/groff-1.23.0.rc4/build-64'
> FAIL: contrib/gdiffmk/tests/runtests.sh
>   GEN      contrib/hdtbl/examples/test-hdtbl.sh
> SKIP: contrib/hdtbl/examples/test-hdtbl.sh
> PASS: contrib/mm/tests/LT_SP_AU_without_AT_works.sh
> PASS: contrib/mm/tests/LT_SP_multi-word_LO_SJ_works.sh
> PASS: contrib/mm/tests/MT-1-reports-all-TM-numbers.sh
> PASS: contrib/mm/tests/MT_5_includes_AT_in_SG.sh
> PASS: contrib/mm/tests/P-indentation-works.sh
> PASS: contrib/mm/tests/ms_cover_sheet_robust_to_missing_AF.sh
> PASS: contrib/mm/tests/mse_has-sufficient-footnote-space.sh
> PASS: contrib/mm/tests/place-equation-labels-correctly-in-displays.sh
> PASS: contrib/mm/tests/remove-stale-bib-entry-data.sh
> PASS: contrib/mm/tests/short-pages-do-not-overflow-stack.sh
>   GEN      contrib/mom/examples/tests-mom.sh
> /bin/sh: can't create contrib/mom/examples/tests-mom.sh: nonexistent directory
> make[3]: *** [Makefile:14129: contrib/mom/examples/tests-mom.sh] Error 1
> 
> The directory contrib/mom/ exists. The directory contrib/mom/examples/
> does not exist. What's missing is therefore obviously a command
>   $(MKDIR_P) contrib/mon/examples
> in the contrib/mom/examples/tests-mom.sh rule. In file contrib/mom/mom.am,
> between lines 116 and 117.

I agree with your analysis.  That Make rule was last touched (by me) in
October 2021, but even before that, it never created the destination
directory, all the way back to the invention of the tests-mom.sh script
5 years ago.  I guess it was a latent bug that I managed to expose.

Will fix.

Regards,
Branden

signature.asc
Description: PGP signature