[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Partition modules

From: Marco Gerards
Subject: Re: Partition modules
Date: Thu, 18 Nov 2004 08:16:54 +0000
User-agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux)

Hollis Blanchard <address@hidden> writes:

> I do have an objection here: members like "bsd_type" don't belong in a
> generic struct, but rather in grub_partition_bsd_type. I believe
> grub_partition should be the abstraction, i.e. what defines a
> partition in the general sense. start, len, and index are obviously
> good; offset is compensating for a DOS issue, though at least it has
> (irrelevant) meaning for an Apple map... but ext_offset and these dos_
> and bsd_ things don't belong here IMHO.


> Also, there were a number of whitespace-only lines in your patch; a
> simple regex should show you where.


> I'm seeing a crash on both briQ and my G3, so I'm sprinkling printfs
> now...

Does the PC partition map work on the briQ now?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]