Re: Grub2 on Mac OS X

[Antoine Terrienne]

Selon Marco Gerards <address@hidden>:

>
> If that is used, you could replace int32_t by grub_uint32_t, etc.
>

ok I was wondering if here were a specific reason for using both grub_int32_t
and int32_t types like one for the host part and one for the build part. But if
we can always use grub_xxx types it will make it a lot easier.

>
> Not including generated files will make the patch a lot smaller.  I
> personally don't have problems with big patches on the mailinglist.
> Having the patch in the email will make it a lot easier for me to
> review the patch.
>
> Please use -p as well.  It will make reviewing the patch a *LOT*
> easier.
>

Ok I will do this

> First you have to compile GRUB 2.  After that you can use grub-mkimage
> to create an ELF file that is loadable by open firmware.  Using
> grub-mkimage you should specify the name of the output executable and
> which modules should be included.  For testing you should at least include
> apple.mod, ext2.mod, hfs.mod, ls.mod and normal.mod I think.
>
> After that I just load it using "boot" or tftp.
>

Thank's I will try

>
> I thought GRUBOF was not used anymore, but I see you replaced it.  I
> hope I can find some time to have a look at your patch soon, but
> please understand if it will take a while.
>

Yes GRUBOF have been removed from everywere exept in one .h file in the powerpc
part. Must have been forgotten. In fact many little problems like this one
seems to come from some great improvements made to Grub2-i386 that have not
been ported to the powerpc part.

>
> Cool!  please check if your modification did not add any warnings or
> so, we would like to keep GRUB quite clean.
>

most warnings come from the memcpy function that conflicts with the gcc builtin.

> A complete review has to follow... sorry...
>

No problem there's no rush.
By the way I will probably put a more complete patch in a few days with all your
remarks.

Thank's

--
--
  ____
 /    \  / address@hidden
|  o o | - http://antoine.terrienne.free.fr
|   o  | \ #153026466
\  V V /
 \_/\_/