[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Huge changes in mm.c

From: Vincent Pelletier
Subject: Re: [PATCH] Huge changes in mm.c
Date: Tue, 12 Jul 2005 13:14:57 +0200
User-agent: Debian Thunderbird 1.0.2 (X11/20050602)

Hash: SHA1

Vincent Guffens wrote:
> Vincent Pelletier wrote:
> It must be released by the one who called the malloc.

I don't see any good reason to forget - on kernel side - this chunk, as
we still keep the struct member in memory.
Anyway, I've done some other major changes to this patch, now the chunks
are a simple chained list. That prevents bugs like thinking the first
chunk is right after the last one in memory.
The new code is also much lighter on dprintf. I'll send a patch when
I'll have solved what I think is the last bug which only triggers on
x86: malloc returns sometime out of region pointers...

> grub_size_t n = ((size + GRUB_MM_ALIGN - 1) >> GRUB_MM_ALIGN_LOG2) + 1;
> which adds the extra block for the header.

I prefer relying on sizeof when it comes to allocating space instead of
such formula. If we ever change the struct size, it would break in a
strange way - like all memory allocation problems.

Vincent Pelletier
Version: GnuPG v1.4.1 (GNU/Linux)



Appel audio GRATUIT partout dans le monde avec le nouveau Yahoo! Messenger 
Téléchargez cette version sur

reply via email to

[Prev in Thread] Current Thread [Next in Thread]