grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] strncpy misuse in ufs.c]


From: Lubomir Kundrak
Subject: Re: [patch] strncpy misuse in ufs.c]
Date: Wed, 12 Apr 2006 08:06:30 +0200
User-agent: Mutt/1.4.2.1i

EEh.... should actually read

--- ufs.c.orig  2006-04-10 12:17:10.000000000 +0200
+++ ufs.c       2006-04-10 12:17:32.000000000 +0200
@@ -400,7 +400,7 @@
   unsigned int pos = 0;
   int dirino;

-  grub_strncpy (fpath, path, grub_strlen (path));
+  grub_strncpy (fpath, path, sizeof (fpath)+);

   /* Skip the first slash.  */
   if (name[0] == '/')


On Tue, Apr 11, 2006 at 02:08:22PM +0200, Lubomir Kundrak wrote:
> X-Original-To: address@hidden
> Delivered-To: address@hidden
> Date: Tue, 11 Apr 2006 14:08:22 +0200
> From: Lubomir Kundrak <address@hidden>
> To: address@hidden
> Mail-Followup-To: Lubomir Kundrak <address@hidden>, address@hidden
> User-Agent: Mutt/1.4.2.1i
> Subject: [patch] strncpy misuse in ufs.c]
> X-BeenThere: address@hidden
> X-Mailman-Version: 2.1.5
> Precedence: list
> Reply-To: The development of GRUB 2 <address@hidden>
> List-Id: The development of GRUB 2 <grub-devel.gnu.org>
> List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
>       <mailto:address@hidden>
> List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
> List-Post: <mailto:address@hidden>
> List-Help: <mailto:address@hidden>
> List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
>       <mailto:address@hidden>
> Errors-To: address@hidden
> 
> Now again, to correct list.
> Below is the little fix for fs/ufs.c
> 
> --- ufs.c.orig  2006-04-10 12:17:10.000000000 +0200
> +++ ufs.c       2006-04-10 12:17:32.000000000 +0200
> @@ -400,7 +400,7 @@
>    unsigned int pos = 0;
>    int dirino;
> 
> -  grub_strncpy (fpath, path, grub_strlen (path));
> +  grub_strncpy (fpath, path, grub_strlen (path)+1);
> 
>    /* Skip the first slash.  */
>    if (name[0] == '/')
> 
> regards,
> lubo
> 
> -- 
>   o   Lubomir Kundrak
>  *O*  <address@hidden>, http://skosi.org/~lkundrak/
>  (_)  SKOSI -- Slovak OpenSource Initiative
> 
> 
> 
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel

-- 
  o     Lubomir Kundrak
 *O*    <address@hidden>, http://skosi.org/~lkundrak/
 (_)    SKOSI -- Slovak OpenSource Initiative




reply via email to

[Prev in Thread] Current Thread [Next in Thread]