[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] set-colors

From: Hollis Blanchard
Subject: Re: [patch] set-colors
Date: Thu, 20 Apr 2006 20:49:00 -0500

On Apr 20, 2006, at 8:18 PM, Hollis Blanchard wrote:

2nd: after the tests were successful, I changed my OpenFirmware
configuration and switched to grubof.modules. After reboot, I got a
black screen. What happens is that grub does boot, but it shows black on
black text, so you can't see anything. Pressing enter to boot your
default entry works as expected, and Linux boots.

Hmmm. It looks like we're using "call-method color!" to set colors. BootX is using "call-method set-colors" instead, and ybin does the same (but from Forth). I'm guessing the "color!" method doesn't exist in your card's firmware, and we should move to "set-colors" instead.

Vincent, do you know how/if this will affect Sparc? If OpenBoot doesn't have "set-colors", we can abstract it into an arch-specific function, but it would be nice if it does.

Jordi and Vincent, could you both please try this patch? It's working for me (but of course so was "color!").


Index: kern/ieee1275/ieee1275.c
RCS file: /sources/grub/grub2/kern/ieee1275/ieee1275.c,v
retrieving revision 1.2
diff -u -p -r1.2 ieee1275.c
--- kern/ieee1275/ieee1275.c    21 Aug 2005 18:42:55 -0000      1.2
+++ kern/ieee1275/ieee1275.c    21 Apr 2006 01:46:54 -0000
@@ -536,6 +536,7 @@ grub_ieee1275_set_color (grub_ieee1275_i
     struct grub_ieee1275_common_hdr common;
     char *method;
     grub_ieee1275_ihandle_t ihandle;
+    grub_ieee1275_cell_t numcolors;
     grub_ieee1275_cell_t index;
     grub_ieee1275_cell_t b;
     grub_ieee1275_cell_t g;
@@ -545,8 +546,9 @@ grub_ieee1275_set_color (grub_ieee1275_i

   INIT_IEEE1275_COMMON (&args.common, "call-method", 6, 1);
-  args.method = "color!";
+  args.method = "set-colors";
   args.ihandle = ihandle;
+  args.numcolors = 1;
   args.index = index;
   args.r = r;
   args.g = g;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]