[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] don't assume floppy device exists

From: Marco Gerards
Subject: Re: [PATCH] don't assume floppy device exists
Date: Thu, 14 Sep 2006 20:40:53 +0200
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)

Robert Millan <address@hidden> writes:

> grub-install used to fail with "/dev/fd0 not found" errors.  See attached 
> patch.

Thanks for the patch.  Just keep sending them. ;-)

> 2006-09-14  Robert Millan  <address@hidden>
>       * util/i386/pc/grub-mkdevicemap.c:  Make sure floppy device exists
>       before adding it to

I think it would be better to say "the floppy drive", no?

> +      if (stat (name, &st) < 0)
> +     break;

The indentation looks a bit weird in my mailclient.  Please make sure
the b of break is below the space after if.

After that, feel free to commit it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]