[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] avoid recursing into dotdirs

From: Marco Gerards
Subject: Re: [PATCH] avoid recursing into dotdirs
Date: Thu, 14 Sep 2006 20:47:18 +0200
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)

Robert Millan <address@hidden> writes:

> grub-probefs used to recurse into /dev/.static, then come up with
> /dev/.static/dev/hda as my root disk, which later fails to pass the
> pathname-based checks that expect things like /dev/[hsf]d[0-9].
> 2006-09-14  Robert Millan  <address@hidden>
>       * util/i386/pc/getroot.c:  Don't recurse into dotdirs (e.g. ".static").

There is a double space before "Don't", it should be a single space.

> -      if (S_ISDIR (st.st_mode))
> +      if (S_ISDIR (st.st_mode) && ent->d_name[0] != '.')
>       {
> -       /* Find it recursively.  */
> +       /* Find it recursively, but avoid dotdirs (like ".static") since they
> +          could contain duplicates, which would later break the 
> pathname-based
> +          check */

This looks fine, but funny.  I assume you are using tabs where there
should be spaces.  Can you please check that before committing?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]