[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] grub-probefs --root-device

From: Robert Millan
Subject: Re: [PATCH] grub-probefs --root-device
Date: Sat, 23 Sep 2006 09:26:05 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

On Sat, Sep 23, 2006 at 05:20:37AM +0200, Yoshinori K. Okuji wrote:
> However, this usage is against the original meaning, thus the naming is not 
> appropriate any longer. In addition, I don't like that we make an ad-hoc text 
> output (the first line is a fs module name, the second line is a root device 
> name, etc.).
> So I propose that we rename the utility to "grub-probe" and add some options 
> to change the target of grub-probe. The default should be probing a fs to 
> help people who are used to grub-probefs. Here is an example:
> $ grub-probe --target=fs
> ufs
> $ grub-probe
> ufs
> $ grub-probe --target=drive
> (hd0,1)
> $ grub-probe --target=device
> /dev/hda1
> What do you think?

Fine with me.  Please see attached patch (note: for readability I omitted the
rename itself from my patch).

2006-09-23  Robert Millan  <address@hidden>

        * util/i386/pc/getroot.c (grub_guess_root_device): Stop using
        grub_util_biosdisk_get_grub_dev to convert system device to GRUB device.
        * util/grub-emu.c: Use grub_util_biosdisk_get_grub_dev with the string
        returned by grub_guess_root_device.
        * util/i386/pc/grub-setup.c: Ditto.
        * util/i386/pc/grub-probefs.c: Ditto.

        * util/i386/pc/grub-probefs.c: Rename to ...
        * util/i386/pc/grub-probe.c: ... this.
        * DISTLIST: Update reference to grub-probefs.
        * conf/ Ditto.
        * conf/i386-efi.rmk: Ditto.
        * conf/ Ditto.
        * conf/i386-pc.rmk: Ditto.
        * util/i386/pc/ Ditto.

        * util/i386/pc/grub-probe.c: Add --target=(fs|device|drive) option to
        choose which information we want to print.

Robert Millan

My spam trap is address@hidden  Note: this address is only intended for
spam harvesters.  Writing to it will get you added to my black list.

Attachment: print_paths.diff
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]