[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch for kern/efi/mm.c (big memmap)

From: Marco Gerards
Subject: Re: patch for kern/efi/mm.c (big memmap)
Date: Thu, 28 Sep 2006 15:52:22 +0200
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)

Johan Rydberg <address@hidden> writes:

> +  memory_map = grub_efi_allocate_pages
> +    (0, 2 * BYTES_TO_PAGES (memory_map_size + 0x1000));
> I suppose you add 0x1000 to round it up.  Maybe we should change the
> BYTES_TO_PAGES macro to do roundup.

Agreed.  Can you make this change as well?

> I'll attach a unified diff, since those is easier to review.

Wow, I have two unified diffs now, you both make my day. ;-)

> Even through this patch is quite trivial and small, I believe we need
> you to sign over the copyright for it to FSF.  Okuji, Marco, what are
> your opinions?  

This patch is trivial enough to apply without the paperwork, I think.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]