Re: [PATCH] grub-install for EFI

[Yoshinori K. Okuji]

On Friday 11 May 2007 18:11, Robert Millan wrote:
> grub-probe is needed to check partmap (so we don't have to assume gpt).

Yes.

> grub-mkdevicemap is needed to create device.map, without which grub-probe
> won't work.

Right.

> Note: this grub-install.in is based on the i386/pc version.  I tried to
> keep changes minimal, so if you diff them it'll produce readable output.
>
> One thing that I'm not sure about is the CLI inconsistency.  Perhaps it
> shouldn't take the directory as a standalone parameter, and instead use
> --root-directory?

Consistency is important, but it is not a must, as long as the user can easily 
guess the difference. In principle, you should respect consistency, but 
should not blindly believe in it. So if you think it is reasonable to make 
difference, you can. Otherwise, don't.

> Not really sure about these.  Seems ugly, but biosdisk.h has the
> grub_util_biosdisk_get_grub_dev definition, which is not really
> i386/pc-specific.  Also, note that powerpc needs them as well if we
> want update-grub to work there (haven't submitted this part, because it
> grub-probe on powerpc has other issues that I cannot debug).

If it is not specific to i386-pc, it should be moved to somewhere else.

Okuji