[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] bug fix for scripting (update 3)

From: Marco Gerards
Subject: Re: [PATCH] bug fix for scripting (update 3)
Date: Sun, 22 Jul 2007 15:01:04 +0200
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)

Bean <address@hidden> writes:

> This update includes u2 and u2-1, and fix a small problem caused by u2-2.

Oh, I should've waited with the other reviews until I noticed this one.

> -- 
> Bean
> 2007-06-28  Bean  <address@hidden>
>       * kern/parser.c (state_transitions): Exit GRUB_PARSER_STATE_VARNAME
>       state when "/" is encountered.

Which problem does it solve?  At first sight, this looks ok.  If it
fixes something that is ;-).

>       * normal/execute.c (grub_script_argument_to_string): Check for
>       undefined variable.


>       * normal/execute.c (grub_script_execute_cmdline): Reset grub_errno.


>       * normal/main.c (read_config_file): Reset grub_errno.


>       * normal/lexer.c (grub_script_yylex2): Construct arg structure when
>       mixed text is detected.

Please leave this out for now.

>       * normal/lexer.c (check_textstate): Add GRUB_PARSER_STATE_ESC.

Can you explain this?  Is this for Stuff\ Like\ This? :-)

>       * normal/parser.y : Change attribute of token GRUB_PARSER_TOKEN_VAR.

Please leave this out for now.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]