Re: echo gives internal error with \n

[Marco Gerards]

adrian15 <address@hidden> writes:

>   I've activated the echo command (also the pause command) which it is
> equivalent to the echo command... and have done some tests:

The problem is in the parser.

> grub> pause fjfjl
> fjfjl
> grub> pause "fjfjl"
> fjfjl
> grub> pause -n \n
> error: Internal error
>
> grub> pause \n
> error: Internal error
>
> grub> pause -n "\n"
> \n
> grub> pause -e "\n"
>
> grub> echo fasf
> fasf
> grub>
>
>
> Two conclusions from these tests:
>
> 1) When you use \n in string that does not begin with " then it gives an
> internal error. I do not see anything special on echo.c so I suppose
> it's the fault of the parser, however I have not studied the parser
> yet... so marco_g what's your opinnion?

True, Bean sent in a patch to fix this.

> 2) The -e option is not implemented. :) I've checked the code and it is
> not. However I doubt if it's going to work... I ask myself if the grub>
> string always appears at the beginning of the line.

Do you want to implement this? ;-)

This should not be hard to do.

> pause is equivalent to echo command but if you want to check what I am
> saying check my other email that contains a patch for having both echo
> and pause commands.

ok.

--
Marco