[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

NTFS file system driver (update 3)

From: Bean
Subject: NTFS file system driver (update 3)
Date: Sun, 29 Jul 2007 00:44:13 +0800
User-agent: Mutt/1.5.13 (2006-08-11)

On Sun, Jul 22, 2007 at 02:18:23PM +0200, Marco Gerards wrote:
> Was this patch tested on both 32 and 64 bits machines?  And little/big
> endian machines?  Perhaps other people can help Bean if he doesn't
> have access to such machines?

I only test it in 32-bit x86 machines, please report bug if it doesn't work
in other environment.

> One comment in general is that you do not use fshelp.h.  Could you
> please have a quick look at this?  This would help to structure the
> code a bit more like the other filesystem implementations and save
> some code and complexity.  If it can be used (in a sane way), please
> do :-)

I've rewritten the directory searching code to use grub_fshelp_find_file. But
I don't use grub_fshelp_read_file to read files, becasue the fshelp
implementation don't work well with ntfs filesystem.

> What are you caching and how would that work?

I'm caching the last read cluster, which can be 512 to 4192 long. If the next
read is from the same cluster, no disk access is needed.

The buffer is attr->sbuf, it's released in free_attr.

> Why are you using these hooks?  I think they are meant for the users
> of the filesystem, so they can build a blocklist or so and not for the
> filesystems.  Are you really sure this is required?

The hook is used to get the disk layout of a file. But sometimes the driver
needs to read from system structure like mft. So I'm enabling the hook only
when it's reading data blocks.

> In this case the mtf->buf leaks, right?  Same for the returns below I
> think when returning 0.

The memory is released in free_file:



Attachment: grub2-ntfs-u3.diff
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]