[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fix serial console on LinuxBIOS
From: |
Robert Millan |
Subject: |
Re: [PATCH] fix serial console on LinuxBIOS |
Date: |
Fri, 9 Nov 2007 22:34:01 +0100 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Fri, Nov 09, 2007 at 04:30:44PM +0100, Marco Gerards wrote:
> Robert Millan <address@hidden> writes:
>
> > This patch fixes serial console on LinuxBIOS.
> >
> > I'd appreciate comments (specially on the <grub/machine/machine.h>
> > addition).
> >
> > --
> > Robert Millan
> >
> > <GPLv2> I know my rights; I want my phone call!
> > <DRM> What use is a phone call, if you are unable to speak?
> > (as seen on /.)
> >
>
> No header ;)
Uhm what header?
> > * include/grub/i386/efi/machine.h: New file.
> > * include/grub/i386/linuxbios/machine.h: Likewise.
> > * include/grub/i386/pc/machine.h: Likewise.
> > * include/grub/powerpc/ieee1275/machine.h: Likewise.
> > * include/grub/sparc64/ieee1275/machine.h: Likewise.
> >
> > * term/i386/pc/serial.c: Include <grub/machine/machine.h>.
> > (serial_hw_io_addr): New variable.
> > (serial_hw_get_port): Obtain port address from `serial_hw_io_addr'
> > instead of `(unsigned short *) 0x400'.
>
> This seems fine to me. What is your intended use for machine.h? More
> than just this?
Situations very similar to this one, in that you just need to change a few
unportable lines while the overall structure of the file remains portable.
> Perhaps we can even use autoconf to define this in config.h? That
> would be better I think.
autoconf already setups the cpu / machine symlinks. Why ask it to tell the
same info twice?
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)