grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix for linker build ID in Fedora 8


From: Pavel Roskin
Subject: Re: [PATCH] Fix for linker build ID in Fedora 8
Date: Mon, 26 Nov 2007 07:35:40 -0500

Hello!

On Mon, 2007-11-26 at 11:28 +0100, Lubomir Kundrak wrote:

> > I attach the patch I use. The first hunk is basically the same as yours,
> > the second one is self-explanatory.
> 
> Actually, the first hunk should better look like this:
> http://lists.gnu.org/archive/html/grub-devel/2007-11/msg00187.html

The objcopy test exists to detect certain breakage in objcopy.  I'm not
sure that testing it in the condition that it only copies .text is
sufficient to find the original problem.  Surely, that will need some
software archeology.  The test comes from GRUB 1.  Anyway, I'll rather
test objcopy under conditions close to those used in the build process.

And what's the build ID for?  Why do we want to keep it?

-- 
Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]