[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: contradiction in boot/i386/pc/boot.S
From: |
Pavel Roskin |
Subject: |
Re: contradiction in boot/i386/pc/boot.S |
Date: |
Tue, 08 Jan 2008 13:24:25 -0500 |
On Tue, 2008-01-08 at 11:50 +0100, Robert Millan wrote:
> boot_drive_check:
> jmp 1f /* grub-setup may overwrite this jump */
> testb $0x80, %dl
> jnz 1f
> movb $0x80, %dl
> 1:
>
> However, if 0x80 is really "the only possible boot drive", that means the
> test is pointless and can be replaced with:
No, I was wrong, I misread "testb" as "cmpb". Values such as 0x81 are
valid and should be preserved.
Please ignore my previous message.
--
Regards,
Pavel Roskin