Re: [PATCH] jpeg image reader

[Bean]

On Jan 15, 2008 7:01 PM, Marco Gerards <address@hidden> wrote:
> > static grub_err_t
> > grub_jpeg_decode_sof (struct grub_jpeg_data *data)
> > {
> >   int i, cc;
> >   grub_uint32_t next_marker;
> >
> >   next_marker = data->file->offset;
> >   next_marker += grub_jpeg_get_word (data);
> >
> >   if (grub_jpeg_get_byte (data) != 8)
> >     return grub_error (GRUB_ERR_BAD_FILE_TYPE,
> >                      "jpeg: only 8-bit precision is supported");
> >
> >   data->image_height = grub_jpeg_get_word (data);
> >   data->image_width = grub_jpeg_get_word (data);
> >
> >   if ((!data->image_height) || (!data->image_width))
> >     return grub_error (GRUB_ERR_BAD_FILE_TYPE, "jpeg: invalid image size");
> >
> >   cc = grub_jpeg_get_byte (data);
> >   if (cc != 3)
> >     return grub_error (GRUB_ERR_BAD_FILE_TYPE,
> >                      "jpeg: component count must be 3");
> >
> >   for (i = 0; i < cc; i++)
> >     {
> >       int id, ss;
> >
> >       id = grub_jpeg_get_byte (data) - 1;
> >       if ((id < 0) || (id >= 3))
> >       return grub_error (GRUB_ERR_BAD_FILE_TYPE, "jpeg: invalid index");
> >
> >       ss = grub_jpeg_get_byte (data); /* sampling factor  */
> >       if (!id)
> >       {
> >         data->vs = ss & 0xF;  /* vertical sampling  */
> >         data->hs = ss >> 4;   /* horizontal sampling  */
>
> Please use correct interpunction.

I'm sorry, what do you mean by correct interpunction ?

-- 
Bean