[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Redefining GRUB_MOD_GAP in init.c

From: Pavel Roskin
Subject: Redefining GRUB_MOD_GAP in init.c
Date: Sun, 27 Jan 2008 22:25:32 -0500

Hi Robert,

I'm concerned about your latest commit:

        * kern/powerpc/ieee1275/init.c (grub_arch_modules_addr): Skip
        `GRUB_MOD_GAP' for platforms in which it's not defined.

The algorithm for calculating the start of the modules should be exactly
the same in grub-mkimage and in the core.  Any fallbacks should be
coherent if possible.  Therefore, I think it would be better to define
GRUB_MOD_GAP only in header files.

It's hard for me to understand why kern/powerpc/ieee1275/init.c can be
used on any platform other than PowerPC.  I was assuming that my changes
would not affect other platforms.

Also, I don't see how GRUB_MOD_GAP would not be defined to 0x8000 for
i386-ieee1275 platform considering that
include/grub/i386/ieee1275/kernel.h simply includes

I suggest that i386-ieee1275 stops using any files for PowerPC.
kernel.h is not big, so it shouldn't be a problem to copy it.  As for
init.c, it should be either copied or moved to a more suitable place.

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]