[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] simplify grub_raid_array
|
From: |
Jeroen Dekkers |
|
Subject: |
Re: [PATCH] simplify grub_raid_array |
|
Date: |
Wed, 06 Feb 2008 23:43:39 +0100 |
|
User-agent: |
Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.7 Emacs/22.1 (x86_64-pc-linux-gnu) MULE/5.0 (SAKAKI) |
At Wed, 6 Feb 2008 17:45:07 +0100,
Robert Millan wrote:
> Unless I missed something, it seems that grub_raid_array contains redundant
> information (`name' is already present via `disk->name'). I propose to
> simplify it this way.
No idea why, I don't have the time to look at the actual code, but
> @@ -410,7 +410,7 @@ grub_raid_scan_device (const char *name)
> return 0;
> }
>
> - if (array->device[sb.this_disk.number].name != 0)
> + if (array->device[sb.this_disk.number]->name != 0)
> {
> /* We found multiple devices with the same number. Again,
> this shouldn't happen.*/
looks suspicious to me. Is that really doing what it is meant to do?
Regards,
Jeroen Dekkers