[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tell the user why they are in rescue mode
From: |
Robert Millan |
Subject: |
Re: [PATCH] tell the user why they are in rescue mode |
Date: |
Fri, 8 Feb 2008 20:15:39 +0100 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Fri, Feb 08, 2008 at 06:44:26PM +0000, Sam Morris wrote:
>
> While that works, the output looks like this:
>
> Entering rescue mode...
> error: out of disk
> > _
>
> Which does not present the information in the clearest possible way: it
> looks like the error happened in the rescue mode code, instead of the
> normal mode code.
>
> Also, the error message could be lost if any of the code between the
> start of grub_enter_rescue_mode and its call to grub_print_error itself
> triggers an error.
>
> For these reasons I think it's better to call grub_print_error from
> within grub_load_normal.
Agreed. See attached patch. Does this work as expected ?
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)
rescue_mode.diff
Description: Text Data