[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [NEW PATCH] Add option to grub-probe to accept system devices as arg
From: |
Robert Millan |
Subject: |
Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments |
Date: |
Thu, 28 Feb 2008 18:07:38 +0100 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Thu, Feb 28, 2008 at 12:46:37PM +0100, Fabian Greffrath wrote:
>
> if [ -x "`which os-prober 2>/dev/null`" ] ; then
Better do this like it's done in other scripts (check grub-install). Not sure
why, I guess it's more portable that way...
> if [ -x "`which linux-boot-prober 2>/dev/null`" ] ; then
same here.
> hurd)
> # not yet...
> ;;
For this one, I think it'd be much better to rework 10_hurd so that code is
shared, rather than duplicating the whole blurb.
Do you plan to do that later?
Btw, what about *BSD? Does os-prober detect those as "chain" or ... ?
> *)
> ;;
Maybe it's better to echo something here, otherwise it gives the impression
OS FooBar was just detected and properly added.
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)
- [NEW PATCH] Add option to grub-probe to accept system devices as arguments, (continued)
- [NEW PATCH] Add option to grub-probe to accept system devices as arguments, Fabian Greffrath, 2008/02/22
- Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments, Fabian Greffrath, 2008/02/22
- Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments, Robert Millan, 2008/02/24
- Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments, Fabian Greffrath, 2008/02/25
- Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments, Robert Millan, 2008/02/25
- Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments, Fabian Greffrath, 2008/02/28
- Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments, Robert Millan, 2008/02/28
- Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments, Fabian Greffrath, 2008/02/28
- Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments, Robert Millan, 2008/02/28
- Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments, Fabian Greffrath, 2008/02/28
- Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments,
Robert Millan <=
- Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments, Fabian Greffrath, 2008/02/29
- Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments, Fabian Greffrath, 2008/02/29
- Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments, Robert Millan, 2008/02/24