[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix prefix problem with LVM on RAID

From: Guntsche Michael
Subject: Re: [PATCH] Fix prefix problem with LVM on RAID
Date: Sun, 13 Apr 2008 18:07:22 +0200

On Apr 13, 2008, at 17:04, Robert Millan wrote:
On Sat, Feb 23, 2008 at 09:54:35PM +0100, Michael Guntsche wrote:

While testing a soon to be deployed setup here I noticed that grub-
setup is setting the prefix wrong if you run
LVM on Software RAID

grub-setup -v /dev/md0
grub-setup: info: dos partition is -2, bsd partition is -2, prefix is

As you can see the there is also (md0) in the prefix which does not
Attached a small patch that fixes this problem for me. I am not sure
if it is the best way to fix it so please take a look.
If the root device is on LVM only add the LVM part if it is on RAID
only add the RAID part.

Sorry for the delay in repliing. I think it's more correct this way. Does
it work for you?

Hello Robert,

Take a look at the for loop later on in the MD case, that is not being called with your patch. The code gets all RAID disks and calls setup on each of them. I do not think the setup call further down is doing the same thing, haven't checked it though. With my patch "setup" is still called for each RAID member with the correct prefix. In the case of a faulty disk you can still boot from the degraded array, by choosing a different disk.

Kind regards,

Attachment: smime.p7s
Description: S/MIME cryptographic signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]