[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix file name transformations (mostly)

From: Pavel Roskin
Subject: Re: [PATCH] Fix file name transformations (mostly)
Date: Tue, 15 Apr 2008 15:19:59 -0400

On Tue, 2008-04-15 at 00:12 +0200, Lubomir Kundrak wrote:
> Hi,
> Attaching the patch that fixes ./configure's --program-transform-name
> option. Tested with --program-transform-name=s,grub,grub2, quite
> extensively. Only one more modification is needed to completely support
> this -- define DEFAULT_DIRECTORY with -D option of the preprocessor
> instead of hardcoding in include/grub/util/misc.h. Should be fairly
> trivial though.

I would prefer if we don't rush with "program-transform-name" at the
expense of readability, but rather make other simplifications what would
have a similar effect.  I think ${libdir}/grub should be given a name
(e.g. grublibdir) in and substituted in the scripts.

As for /boot/grub, we are not installing anything there on "make
install".  I don't think it should be transformed.  But we could accept
a configuration option to change that directory.

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]